[WIP] Implementation of QR Decomposition #29
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbull
force-pushed
the
feature/qr_decomposition
branch
from
c95152b to
71e6b9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR introduces an implementation of QR Decomposition based on the existing Gram-Schmidt algorithm in Symbolica. However, I overlooked an important detail: the current Gram-Schmidt implementation only orthogonalizes the vectors but does not normalize them. As a result, the QR decomposition in this PR does not correctly factorize the matrix as expected.
To ensure correctness, further modifications are required to properly normalize the vectors and obtain a truly orthonormal Q matrix. This PR serves as a work-in-progress snapshot to illustrate the current state and facilitate further discussion and improvements.