Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact!: remove tables concept + rewrite with FastAPI #42

Merged
merged 46 commits into from
Aug 28, 2023
Merged

refact!: remove tables concept + rewrite with FastAPI #42

merged 46 commits into from
Aug 28, 2023

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed
fix: remove codecov dev dep
6f65c22
@davidlougheed
ci: use codecov github action
381f7c1
@davidlougheed
chore: use poetry-managed venvs
f1cfb6b
@davidlougheed
chore!: drop support for python < 3.10
d1b9062
@davidlougheed
chore: update dev deps
0e2b2d2
@davidlougheed
chore: add fastapi and pydantic-settings dependencies
ba3af56
@davidlougheed
add pydantic-based config class
8e63a62
@davidlougheed
refact!: initial portion of fastapi/tables-removal refactor
a600259
@davidlougheed
lint: modernize type hints
b65d07d
@davidlougheed
ci: replace python 3.8 with 3.11
e06f853
@davidlougheed
chore: update dependencies and remove tornado
5385790
@davidlougheed
refact!: fetch data services from service registry & use for search; …
43e1f38 
…use aiohttp
@davidlougheed
refact!: rewrite dataset search workers to remove tornado-style code
1b1f741
@davidlougheed
lint: rm dead code
ea1b19e
@davidlougheed
refact: use DI for http client sessions; add req timeout config
263ad1c
@davidlougheed
refact: util function for forwarding auth / host headers
64e8d60
@davidlougheed
lint: rm dead/broken code
76590cd
@davidlougheed
refact: less giant try/catch blocks in handlers.datasets
30e9383
@davidlougheed
ci: fix lint workflow
4997d5e
@davidlougheed
ci: fix test workflow
ac060c0
@davidlougheed
fix: dockerfile poetry issues
7a576af
@davidlougheed
chore: update uvicorn in docker images
83a0a02
@davidlougheed
chore: update base image version
050c48c
@davidlougheed
lint
4f6b050
@davidlougheed
chore: add pytest and pytest-cov
6ff0433
@davidlougheed
tests: rewrite tests for fastapi; fix tox / poetry
262caa1
@davidlougheed
fix: prod dockerfile
49eb67b
@davidlougheed davidlougheed marked this pull request as ready for review August 15, 2023 19:32
v-rocheleau
v-rocheleau approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

bento_aggregation_service/search/dataset_search.py Outdated Show resolved Hide resolved
@davidlougheed davidlougheed merged commit cb61481 into master Aug 28, 2023
5 checks passed
@davidlougheed davidlougheed deleted the refact/fastapi-rewrite branch August 28, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-rocheleau v-rocheleau v-rocheleau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @v-rocheleau