anonymous metadata queries should use discovery config only #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -169,6 +169,9 @@ class Config: | |||
| PHENOPACKETS_SCHEMA_REFERENCE = {"entityType": "individual", "schema": "phenopackets v1"} | |||
|
|
|||
| MAX_RETRIES_FOR_CENSORSHIP_PARAMS = 2 | |||
|
|
|||
| # don't let anonymous users query arbitrary phenopacket or experiment fields | |||
| ANONYMOUS_METADATA_QUERY_USES_DISCOVERY_CONFIG_ONLY = True | |||
There was a problem hiding this comment.
technically these aren't anonymous users per se, just ones without query:data - could be called CENSORED_METADATA_QUERY_USES_DISCOVERY_CONFIG_ONLY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anonymous users should not have access to arbitrary fields in phenopackets or experiments metadata (for example they should not be able to query subject ids). So anonymous queries about metadata should use values from discovery config only.
Changes:
reject_query_if_not_permitted()to request handling (throws "bad request" for forbidden queries)