-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add toggle-able Bento authorization middleware #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlougheed
changed the title
[WIP] Add toggle-able Bento authorization middleware
Add toggle-able Bento authorization middleware
Jul 26, 2023
davidlougheed
changed the title
Add toggle-able Bento authorization middleware
feat!: add toggle-able Bento authorization middleware
Jul 26, 2023
gsfk
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay great! Just a few comments so far:
Werkzeug version needs to be <2.3 (werkzeug issue, debugpy issue)
Info endpoints (the ones in info.py) do not require auth.
returns 403 in a lot of cases where another response would be better, eg:
- masks all 500 errors as 403, even in dev mode
- beacon endpoints are configurable, they can be toggled on and off in the main beacon_config.json. So for example it's possible to have a beacon that implements
/individuals
but not/g_variants
. In this case the corresponding flask blueprint is never loaded. For these endpoints 404 would be be better. - For the functions that have
raise NotImplemented()
as their body, some of these will get full auth implementations, and the rest I'll remove outright. Ideally the ones that are removed entirely will return 404.
gsfk
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this doesn't implement any full-response endpoints or much in the way of complex fallback/different responses - just setting up the basics