Re-attempt censorship settings on query #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlougheed
approved these changes
Mar 27, 2024
bento_beacon/utils/censorship.py
Outdated
|
|
||
|
|
||
| # saves settings to config as a side effect | ||
| def censorship_retry(): |
There was a problem hiding this comment.
would be nice to have return type hints on this function and the two below (tuple[int | None, int | None], int | None), but otherwise this PR looks good
There was a problem hiding this comment.
Thanks... I've started adding these incrementally where they're helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code to re-attempt retrieving censorship settings from katsu.
Beacon calls katsu at startup for censorship settings, but currently fails permanently after a set number of retries. This pr adds code to re-attempt retrieving censorship settings whenever a query is made, if censorship settings are missing. The number of retries at startup is also lowered.
At some point we may decide that retrieving at startup is no longer necessary, and use the query-driven system only.