ignore dataset description if katsu down #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlougheed
requested changes
Apr 25, 2024
| try: | ||
| response = katsu_get(endpoint, id, query="format=phenopackets") | ||
| except APIException: | ||
| return {} |
There was a problem hiding this comment.
add a log warning message or something if this happens, with the APIException contents?
There was a problem hiding this comment.
or is this handled in katsu_get
There was a problem hiding this comment.
yes, this will be logged already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects an issue where
/service-infowould return an invalid response when katsu is down (it would return an error response in beacon format, but that doesn't match the spec for service-info). Also allows the root endpoint/to return service details even when katsu is down, instead of an error response.Some info endpoints will still return errors when katsu is down (
/info,/overviewand others) but this is expected.