Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/last_ingestion #94

Merged
merged 32 commits into from
Aug 1, 2023
Merged

Features/last_ingestion #94

merged 32 commits into from
Aug 1, 2023

Conversation

noctillion
Copy link
Contributor

This PR introduces changes in backend and a new component, LastIngestionPublic. This component is designed to display the most recent ingestion information that is available, from WES service endpoint Features/public-last-ingestion-retrival #40.

Changes include:

  • Changes in publich backend to request information about last ingested files from wes service
  • Addition of the LastIngestionInfo component
  • Necessary updates in redux and related components for proper integration

@noctillion
Implements WES API requests for last ingestion inf
2528cd9
@noctillion
add info to default translation
b937c57
@noctillion
Set types for latest ingestion response
80cae99
@noctillion
Component for displaying the latest ingestion info
100cece
@noctillion
Refactor: Replace RunData with ingestionData
e1de309
@noctillion
Add: store slice for managing last ingestion data
f7322e0
@noctillion
Added lastIngestionsUrl constant to '/wesruns
31f3321
@noctillion
Added component import for LastIngestionInfo
9ae185f
@noctillion
Added dispatch for makeGetIngestionDataRequest
8075626
@noctillion
Included IngestionDataReducer in Redux store
f14e7c8
@noctillion
prettier
e9876b6
@noctillion
refactor endpoint for wes public runs
973520e
@noctillion
refactor ingestionData types
a0f5ebd
@noctillion
refactor for ingestionData structure
bf813c3
@noctillion
refactor wesruns request
365f625
@noctillion
refactoring LastIngestionInfo for data structure
0e7fb23
@noctillion
refactor for new data structure
d007b1f
@noctillion
last ingestion times by data type to state
4c74079
@noctillion
Merge branch 'main' into features/last_ingestion
e7b00c4
@noctillion
lint
2c7c954
davidlougheed
davidlougheed requested changes Jul 26, 2023
View reviewed changes
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
src/js/features/ingestion/ingestion.store.ts Show resolved Hide resolved
src/js/components/Overview/LastIngestion.tsx Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
davidlougheed
davidlougheed requested changes Jul 26, 2023
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor requests

src/js/components/Overview/LastIngestion.tsx Outdated Show resolved Hide resolved
src/js/components/Overview/LastIngestion.tsx Show resolved Hide resolved
davidlougheed
davidlougheed requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor reqs, other than that looks good

src/js/types/lastIngestionResponse.ts Outdated Show resolved Hide resolved
src/js/types/lastIngestionResponse.ts Outdated Show resolved Hide resolved
@noctillion
Copy link
Contributor Author

Thank you for your insightful review and valuable feedback!

davidlougheed
davidlougheed requested changes Jul 31, 2023
View reviewed changes
src/js/store.ts Outdated Show resolved Hide resolved
src/js/components/Overview/LastIngestion.tsx Outdated Show resolved Hide resolved
src/js/components/Overview/LastIngestion.tsx Show resolved Hide resolved
davidlougheed
davidlougheed requested changes Jul 31, 2023
View reviewed changes
src/js/features/ingestion/ingestion.store.ts Outdated Show resolved Hide resolved
src/js/types/lastIngestionResponse.ts Outdated Show resolved Hide resolved
src/js/types/lastIngestionResponse.ts Outdated Show resolved Hide resolved
@noctillion noctillion merged commit 8c37772 into main Aug 1, 2023
2 checks passed
@davidlougheed davidlougheed deleted the features/last_ingestion branch August 30, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noctillion @davidlougheed