fix: chart click nav #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/js/components/Search/Search.tsx
Outdated
| @@ -61,6 +65,10 @@ const RoutedSearch: React.FC = () => { | |||
| const queryParam = new URLSearchParams(location.search); | |||
| const { valid, validQueryParamsObject } = validateQuery(queryParam); | |||
| if (valid) { | |||
| console.log({ | |||
There was a problem hiding this comment.
change to a console.debug with some kind of info about whats being logged, or remove
There was a problem hiding this comment.
Forgot to remove, was only to debug
src/js/components/Search/Search.tsx
Outdated
| const qp2Keys = Object.keys(qp2); | ||
| const params = [...new Set([...qp1Keys, ...qp2Keys])]; | ||
| return params.reduce((acc, v) => acc && qp1[v] === qp2[v], true); | ||
| } |
There was a problem hiding this comment.
return to original form to reduce diff? or is it better as not a one-liner...
There was a problem hiding this comment.
I like one-liners, but in this case I think it is easier to read/debug this way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chart click navigation was failing due to a faulty query parameters check (Search.tsx checkQueryParamsEqual).
Given the parameter "age", the function would spread each letter as its own parameter ("a", "g", "e"), causing
undefined === undefinedwhich evaluates to true always.