Skip to content

Commit

Permalink
fix: project-level runs hypothetical valid case
Browse files Browse the repository at this point in the history
  • Loading branch information
davidlougheed committed Jul 6, 2023
1 parent e0c4d01 commit 5212559
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions bento_wes/runs.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,13 @@ def _get_project_and_dataset_id_from_run_request(run_request: dict) -> tuple[str

def _check_runs_permission(runs_project_datasets: list[tuple[str, str]], permission: str) -> tuple[bool, ...]:
return authz_middleware.authz_post(request, "/policy/evaluate", body={
"requested_resource": [{
"project": project_id,
"dataset": dataset_id,
} for project_id, dataset_id in runs_project_datasets],
"requested_resource": [
{
**({"project": project_id} if project_id else {}),
**({"dataset": dataset_id} if dataset_id else {}),
}
for project_id, dataset_id in runs_project_datasets
],
"required_permissions": [permission],
}).json()["result"]

Expand Down Expand Up @@ -276,11 +279,6 @@ def run_list():
run_req = run_request_dict(r)

project_id, dataset_id = _get_project_and_dataset_id_from_run_request(run_req)

if project_id is None or dataset_id is None:
logger.error(f"Invalid run encountered (missing project_id or dataset_id in request tags): {r['id']}")
continue

perms_list.append((project_id, dataset_id))

if with_details:
Expand Down

0 comments on commit 5212559

Please sign in to comment.