chore: improved datset query coverage

- discovered bug (unknown dataset id returns results)
bento-platform · Jul 10, 2023 · 1048d3f · 1048d3f
1 parent 2340082
commit 1048d3f
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/src/api/tests/build/api/variants_test.go b/src/api/tests/build/api/variants_test.go
@@ -197,6 +197,17 @@ func TestDemoVcfIngestion(t *testing.T) {
 		byDatsetQueryResponse := common.BuildQueryAndMakeGetVariantsCall("", "*", dataset, true, "asc", "", "GRCh38", "", "", "", false, t, cfg)
 		assert.True(t, len(byDatsetQueryResponse.Results) > 0)
 		assert.True(t, len(byDatsetQueryResponse.Results[0].Calls) > 0)
+		// verify dataset ids
+		From(byDatsetQueryResponse.Results).SelectManyT(func(data dtos.VariantGetResult) Query { // *
+			return From(data.Calls)
+		}).ForEachT(func(variant dtos.VariantCall) {
+			assert.Equal(t, dataset.String(), variant.Dataset)
+		})
+
+		// test unknown random dataset id
+		shouldBeEmptyResponse := common.BuildQueryAndMakeGetVariantsCall("", "*", uuid.New(), true, "", "", "GRCh38", "", "", "", false, t, cfg)
+		assert.True(t, len(shouldBeEmptyResponse.Results) > 0)
+		assert.True(t, len(shouldBeEmptyResponse.Results[0].Calls) == 0)
 	})
 
 	t.Run("Test Simple Allele Queries", func(t *testing.T) {