Refactoring to version 9 #260
Conversation
|
@benwinding took me some time to clean up the branch. Most of the changes are in |
|
Hi, will it be merged soon ? |
package.json
Outdated
| "firebase-tools": "11.x", | ||
| "gulp": "^4.0.2", | ||
| "jest": "^23.6.0", | ||
| "microbundle": "^0.15.0", | ||
| "prettier": "^2.8.3", | ||
| "prettier-plugin-organize-imports": "^3.2.2", |
There was a problem hiding this comment.
This prettier package is an aesthetic choice, it shouldn't be included in this PR, as there's tonnes of import changes that have no effect on the behaviour of the system.
Mixing linting & functional changes in the same PR's makes the git history confusing and hard to see exactly what changes something.
I'll allow this, but next time, please restrict PR's to the smallest change necessary to make review easier. Linting PR's on the other hand, can be huge as they're not functional changes.
There was a problem hiding this comment.
@benwinding I reverted all the prettier and tslint changes, but this one slipped in somehow.
Let me know if you want me to revert this back.
There was a problem hiding this comment.
Yeah that would be great actually 🙏 Since this is a major firebase upgrade 👍
There was a problem hiding this comment.
Or just make another PR with the prettier-plugin-organize-imports linting changes, that can get merged in before (so these changes will be reduced)
|
I have a question about the collectionQuery with this new firebase version 9. The usually How to do the equivalent ? I found this in the Firestore doc : This mean we have to import the query from the 'firebase/firestore' plugin ? |
amilosmanli
force-pushed
the
refactoring-to-version-9
branch
from
ae72d63
to
beba28b
Compare
|
@benwinding, I updated the PR. PTAL |
There was a problem hiding this comment.
Thank you for this huge effort @amilosmanli !! 👏
Much easier to see the changes, I'll merge this and deploy a newer minor release soon 👌
| total = (page - 1) * perPage + data.length; | ||
| log('apiGetListLazy', { message: `It's last page of collection.` }); | ||
| } | ||
| let total = await getCountFromServer(noPagination); |
There was a problem hiding this comment.
Wow! I didn't know they added getCountFromServer 👏 🎉
| public auth(): FireAuth { | ||
| return this.app.auth(); | ||
| } | ||
| /** @deprecated */ | ||
| public storage(): FireStorage { | ||
| return this.app.storage(); |
There was a problem hiding this comment.
We should still keep these @deprecated fields, if we remove them, then people's code might break in weird ways
There was a problem hiding this comment.
I'll re-add them, before the deploy 👌
|
Deployed as |
|
@benwinding thank you very much for accepting the changes! let me know if there are any bug reports for 4.1.0. Will be happy to help to resolve them |
|
Hey @amilosmanli I have this issue which normally should have been fixed by your changes! (and using getCountFromServer ) Thanks for the hard work! |
|
Hi everybody!
|
Same error. Do you manage to fix it? |
Refactored code to firebase v9 modular
This is probably a breaking change