validate index size

berachain · Dec 17, 2024 · 9ce2c90 · 9ce2c90
1 parent 60f16c2
commit 9ce2c90
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 0 deletions.
diff --git a/da/blob/types.go b/da/blob/types.go
@@ -53,6 +53,7 @@ type ConsensusSidecars[BlobSidecarsT any] interface {
 }
 
 type Sidecar interface {
+	GetIndex() uint64
 	GetBlob() eip4844.Blob
 	GetKzgProof() eip4844.KZGProof
 	GetKzgCommitment() eip4844.KZGCommitment

diff --git a/da/blob/verifier.go b/da/blob/verifier.go
@@ -83,6 +83,9 @@ func (bv *verifier[_, BlobSidecarsT]) verifySidecars(
 	// check that sidecars block headers match with header of the
 	// corresponding block
 	for i, s := range sidecars.GetSidecars() {
+		if s.GetIndex() >= bv.chainSpec.MaxBlobsPerBlock() {
+			return fmt.Errorf("invalid sidecar Index: %d", i)
+		}
 		if !s.GetSignedBeaconBlockHeader().GetHeader().Equals(blkHeader) {
 			return fmt.Errorf("unequal block header: idx: %d", i)
 		}

diff --git a/da/types/sidecar.go b/da/types/sidecar.go
@@ -84,6 +84,10 @@ func (b *BlobSidecar) HasValidInclusionProof(
 	)
 }
 
+func (b *BlobSidecar) GetIndex() uint64 {
+	return b.Index
+}
+
 func (b *BlobSidecar) GetBlob() eip4844.Blob {
 	return b.Blob
 }

diff --git a/node-core/components/interfaces.go b/node-core/components/interfaces.go
@@ -203,6 +203,7 @@ type (
 	}
 
 	BlobSidecar interface {
+		GetIndex() uint64
 		GetSignedBeaconBlockHeader() *ctypes.SignedBeaconBlockHeader
 		GetBlob() eip4844.Blob
 		GetKzgProof() eip4844.KZGProof