Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos fix #2192

Merged
merged 4 commits into from
Nov 28, 2024
+4 −4
Merged

Typos fix #2192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8fd2e6
typo-Update config.toml.tmpl
romashka-btc Nov 28, 2024
917fd42
typo-Update dispatcher.go
romashka-btc Nov 28, 2024
a08b1ca
typo-Update errors.go
romashka-btc Nov 28, 2024
2353b92
typo-Update state_processor_staking_test.go
romashka-btc Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kurtosis/src/services/blutgang/config.toml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ max_retries = 32
expected_block_time = 13000
# Time between health checks in ms
health_check_ttl = 400
# Supress the health check running info messages
# Suppress the health check running info messages
supress_rpc_check = false

# Note: the admin namespace contains volatile functions and
Expand Down
2 changes: 1 addition & 1 deletion mod/async/pkg/dispatcher/dispatcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (

var _ types.Dispatcher = (*Dispatcher)(nil)

// Dispatcher faciliates asynchronous communication between components,
// Dispatcher facilitates asynchronous communication between components,
// typically services.
type Dispatcher struct {
brokers map[async.EventID]types.Broker
Expand Down
2 changes: 1 addition & 1 deletion mod/state-transition/pkg/core/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ var (
ErrDepositsLengthMismatch = errors.New("deposits lengths mismatched")

// ErrDepositMismatch is returned when a specific deposit listed in
// block is different from the corrispondent one from store.
// block is different from the correspondent one from store.
ErrDepositMismatch = errors.New("deposit mismatched")
Comment on lines +42 to 43
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Consider enhancing the error message based on previous feedback.

Based on previous feedback from PR #2115, consider improving the error message to be more specific about the deposit mismatch without needing to separately include the deposit index, as it's already present in the deposit data.

- ErrDepositMismatch = errors.New("deposit mismatched")
+ ErrDepositMismatch = errors.New("deposit data mismatch between block and store")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// block is different from the correspondent one from store.
ErrDepositMismatch = errors.New("deposit mismatched")
// block is different from the correspondent one from store.
ErrDepositMismatch = errors.New("deposit data mismatch between block and store")


// ErrDepositIndexOutOfOrder is returned when deposits are not in
Expand Down
2 changes: 1 addition & 1 deletion mod/state-transition/pkg/core/state_processor_staking_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import (
)

// TestTransitionUpdateValidators shows that when validator is
// updated (increasing amount), corrensponding balance is updated.
// updated (increasing amount), corresponding balance is updated.
func TestTransitionUpdateValidators(t *testing.T) {
cs := setupChain(t, components.BoonetChainSpecType)
sp, st, ds, ctx := setupState(t, cs)
Expand Down