Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9/n Remove PayloadIDT generic type #2293

Merged
merged 1 commit into from
Dec 20, 2024
Merged

9/n Remove PayloadIDT generic type #2293

merged 1 commit into from
Dec 20, 2024

Conversation

fridrik01
Copy link
Contributor

No description provided.

@fridrik01 fridrik01 self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.

Project coverage is 30.84%. Comparing base (582b803) to head (418fe79).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
payload/builder/builder.go 0.00% 3 Missing ⚠️
payload/builder/payload.go 0.00% 3 Missing ⚠️
execution/engine/engine.go 0.00% 2 Missing ⚠️
node-core/components/engine.go 0.00% 2 Missing ⚠️
node-core/components/payload_builder.go 0.00% 2 Missing ⚠️
payload/cache/payload_id.go 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
+ Coverage   30.82%   30.84%   +0.01%     
==========================================
  Files         333      333              
  Lines       15265    15258       -7     
  Branches       20       20              
==========================================
  Hits         4706     4706              
+ Misses      10234    10227       -7     
  Partials      325      325              
Files with missing lines Coverage Δ
consensus-types/types/payload_requests.go 76.76% <100.00%> (ø)
node-core/components/chain_service.go 0.00% <ø> (ø)
node-core/components/state_processor.go 0.00% <ø> (ø)
payload/cache/payload_id.go 82.97% <87.50%> (ø)
execution/engine/engine.go 0.00% <0.00%> (ø)
node-core/components/engine.go 0.00% <0.00%> (ø)
node-core/components/payload_builder.go 0.00% <0.00%> (ø)
payload/builder/builder.go 0.00% <0.00%> (ø)
payload/builder/payload.go 0.00% <0.00%> (ø)

@fridrik01 fridrik01 changed the title Remove PayloadIDT generic type 9/n Remove PayloadIDT generic type Dec 18, 2024
@fridrik01 fridrik01 marked this pull request as ready for review December 18, 2024 10:22
Copy link
Contributor

@nidhi-singh02 nidhi-singh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fridrik01 fridrik01 force-pushed the remove-blobsidecarst branch 5 times, most recently from 945ed1a to a93e4c6 Compare December 20, 2024 10:35
Base automatically changed from remove-blobsidecarst to main December 20, 2024 10:50
@abi87 abi87 merged commit 497c9b4 into main Dec 20, 2024
15 checks passed
@abi87 abi87 deleted the remove-payloadidt branch December 20, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants