Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10/n Remove BeaconBlockT generic type #2294

Closed
wants to merge 1 commit into from

Conversation

fridrik01
Copy link
Contributor

@fridrik01 fridrik01 commented Dec 18, 2024

EDIT: Replaced with #2297

@fridrik01 fridrik01 self-assigned this Dec 18, 2024
@fridrik01 fridrik01 changed the base branch from main to remove-payloadidt December 18, 2024 11:17
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 6.52174% with 43 lines in your changes missing coverage. Please review.

Project coverage is 31.20%. Comparing base (fe27e3c) to head (ba1c3a2).

Files with missing lines Patch % Lines
beacon/blockchain/finalize_block.go 0.00% 8 Missing ⚠️
cmd/beacond/defaults.go 0.00% 7 Missing ⚠️
beacon/blockchain/process_proposal.go 0.00% 6 Missing ⚠️
consensus/cometbft/service/encoding/encoding.go 0.00% 5 Missing ⚠️
beacon/validator/block_builder.go 0.00% 3 Missing ⚠️
consensus/types/consensus_block.go 0.00% 3 Missing ⚠️
beacon/validator/service.go 0.00% 2 Missing ⚠️
da/blob/factory.go 0.00% 2 Missing ⚠️
node-core/components/block_store.go 0.00% 2 Missing ⚠️
node-core/components/sidecars.go 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           remove-payloadidt    #2294      +/-   ##
=====================================================
+ Coverage              31.13%   31.20%   +0.07%     
=====================================================
  Files                    333      333              
  Lines                  15381    15349      -32     
  Branches                  20       20              
=====================================================
+ Hits                    4789     4790       +1     
+ Misses                 10266    10233      -33     
  Partials                 326      326              
Files with missing lines Coverage Δ
beacon/blockchain/deposit.go 0.00% <ø> (ø)
beacon/blockchain/execution_engine.go 0.00% <ø> (ø)
beacon/blockchain/init_chain.go 0.00% <ø> (ø)
beacon/blockchain/payload.go 0.00% <ø> (ø)
consensus-types/types/block.go 94.28% <100.00%> (-0.06%) ⬇️
node-api/backend/block.go 0.00% <ø> (ø)
node-api/backend/genesis.go 0.00% <ø> (ø)
node-api/backend/randao.go 0.00% <ø> (ø)
node-api/backend/state.go 0.00% <ø> (ø)
node-api/backend/validator.go 0.00% <ø> (ø)
... and 29 more

... and 7 files with indirect coverage changes

@fridrik01 fridrik01 marked this pull request as ready for review December 18, 2024 12:11
@fridrik01
Copy link
Contributor Author

Whoops I

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant