Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(genesis): ensure same view of deposits state between CL and EL #2305

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

calbera
Copy link
Contributor

@calbera calbera commented Dec 19, 2024

Enforce in genesis that CL and EL view of deposits are consistent:

  • EL deposit contract genesisDepositsRoot is same as CL's calculated HTR
  • EL deposit contract depositCount is same as length of gen deposits provided to CL

TODO:

  • Update eth genesis files to include necessary pre-deploy state of EL deposit contract, so that these checks can be validated

@calbera calbera changed the title feat(genesis): ensure same view of deposits state between CL and EL [3/3] feat(genesis): ensure same view of deposits state between CL and EL Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 1.04167% with 95 lines in your changes missing coverage. Please review.

Project coverage is 30.66%. Comparing base (45821be) to head (36f013e).

Files with missing lines Patch % Lines
execution/client/ethclient/eth.go 0.00% 47 Missing ⚠️
execution/deposit/contract.go 0.00% 24 Missing ⚠️
beacon/blockchain/init_chain.go 0.00% 22 Missing ⚠️
node-core/components/deposit_contract.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##           beacon_state_deposits_cleanup    #2305      +/-   ##
=================================================================
- Coverage                          30.83%   30.66%   -0.17%     
=================================================================
  Files                                333      333              
  Lines                              15243    15326      +83     
  Branches                              20       20              
=================================================================
  Hits                                4700     4700              
- Misses                             10219    10302      +83     
  Partials                             324      324              
Files with missing lines Coverage Δ
consensus-types/types/genesis.go 87.50% <100.00%> (ø)
node-core/components/deposit_contract.go 0.00% <0.00%> (ø)
beacon/blockchain/init_chain.go 0.00% <0.00%> (ø)
execution/deposit/contract.go 0.00% <0.00%> (ø)
execution/client/ethclient/eth.go 0.00% <0.00%> (ø)

@calbera calbera changed the title [3/3] feat(genesis): ensure same view of deposits state between CL and EL feat(genesis): ensure same view of deposits state between CL and EL Dec 19, 2024
@calbera calbera changed the title feat(genesis): ensure same view of deposits state between CL and EL [WIP] feat(genesis): ensure same view of deposits state between CL and EL Dec 19, 2024
Base automatically changed from beacon_state_deposits_cleanup to main December 20, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants