This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
fix(precompile): Fix regression where eth_call can cause non-deterministic gas consumption
#1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 23, 2023 21:28
itsdevbear
force-pushed
the
fix-gas-consumption
branch
from
9d6095a to
9a6c42f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
==========================================
- Coverage 54.30% 54.22% -0.08%
==========================================
Files 99 99
Lines 5121 5123 +2
==========================================
- Hits 2781 2778 -3
- Misses 2173 2178 +5
Partials 167 167
|
itsdevbear
changed the title
eth_call can cause issues with block production eth_call can cause non-deterministic gas consumption
ocnc
approved these changes
Sep 24, 2023
calbera
reviewed
Sep 24, 2023
calbera
reviewed
Sep 24, 2023
added 4 commits
September 23, 2023 22:23
This reverts commit 8104805.
itsdevbear
force-pushed
the
fix-gas-consumption
branch
from
a0e1bf4 to
20a814f
Compare
added 2 commits
September 23, 2023 22:59
|
fwiw, I really hate this design, but it will get us unblocked for testnet |
|
We can chat monday, but I really think we should just simplify and prevent precompiles from calling back into the EVM. This would reduce so much complexity fromt the precompile plugin and stop just gross interface contagion. I think the fact that the precompile plugin is manually calling the state plugin is a huge antipattern and generally bad practice. Plugins in general, shouldnt need to know about the existance of other plugins. |
added 2 commits
September 24, 2023 11:40
transmissions12
approved these changes
Sep 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot manipulate the canonical state plugin in another plugin since there is no guarantee made about whether it is in a query or a block. Also setting gas consumption in the state plugin is not required, since the context with the updated gas only occurs in the precompile itself.
This can cause non-determinism in gas consumption between nodes.