Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

fix(script): fix scripts in docker #1213

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix(script): fix scripts in docker #1213

merged 1 commit into from
Oct 10, 2023

Conversation

BrickBera
Copy link
Contributor

@BrickBera BrickBera commented Oct 10, 2023

Summary by CodeRabbit

  • Refactor: Updated the initialization script in e2e/testapp/docker/seed/scripts/seed0-init-step2.sh to directly use /.polard as the home directory path, enhancing the script's simplicity and readability.
  • Chore: Added a license header to e2e/testapp/docker/seed/scripts/set-moniker.sh for legal compliance.
  • Bug Fix: Modified the sed command in set-moniker.sh to correctly replace the moniker value in the configuration file, improving the script's functionality and reliability.

@coderabbitai
Copy link

coderabbitai bot commented Oct 10, 2023

Walkthrough

This update introduces a direct path usage in the polard command and enhances the set-moniker.sh script with a license header and an improved sed command for moniker value replacement.

Changes

File Path Summary
.../seed0-init-step2.sh Removed HOMEDIR variable assignment and directly used /.polard as the home directory path.
.../set-moniker.sh Added a license header and updated the sed command to replace the moniker value in the config file with the argument value.

🐇

In the land of code, changes are afoot,

Paths are direct, no more roundabout. 🔄

Monikers set with a brand new header,

Making our scripts just a little bit better. 📜✨


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 14bbbbd and e2fa32d.
Files selected for processing (2)
  • e2e/testapp/docker/seed/scripts/seed0-init-step2.sh (1 hunks)
  • e2e/testapp/docker/seed/scripts/set-moniker.sh (1 hunks)
Files skipped from review due to trivial changes (1)
  • e2e/testapp/docker/seed/scripts/set-moniker.sh
Additional comments (Suppressed): 1
e2e/testapp/docker/seed/scripts/seed0-init-step2.sh (1)
  • 28-33: The HOMEDIR variable assignment has been removed. Ensure that the HOMEDIR variable is defined elsewhere in the script or the environment, otherwise the polard commands may fail due to an undefined home directory.
- HOMEDIR="/.polard"

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1213 (e2fa32d) into main (14bbbbd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1213   +/-   ##
=======================================
  Coverage   48.61%   48.61%           
=======================================
  Files          77       77           
  Lines        4669     4669           
=======================================
  Hits         2270     2270           
  Misses       2236     2236           
  Partials      163      163           

@BrickBera BrickBera merged commit a5ed999 into main Oct 10, 2023
@BrickBera BrickBera deleted the fix_docker_script branch October 10, 2023 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants