Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

refactor(ante): Remove ante handler as it is not needed #1214

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

itsdevbear
Copy link

@itsdevbear itsdevbear commented Oct 10, 2023

Summary by CodeRabbit

"Refactor: Removed Custom Ante Handler

  • The custom Ante Handler, previously imported from the antelib package, has been removed from the application. This change simplifies the codebase and reduces potential points of failure. Note that this may affect how transactions are processed if you were relying on the custom Ante Handler's functionality."

@coderabbitai
Copy link

coderabbitai bot commented Oct 10, 2023

Walkthrough

The changes primarily focus on the removal of the custom Ante Handler from the application. This is achieved by eliminating the import of the antelib package and setting the Ante Handler to nil in the NewPolarisApp function.

Changes

File Summary
.../testapp/app.go The antelib package import has been removed and the Ante Handler is set to nil, indicating the discontinuation of the custom Ante Handler in the application.

🐇

"In the land of code, where logic is the road,

Changes come and go, like the river's flow.

Farewell to the Ante Handler, its duty is done,

With every setting sun, a new code has begun. 🌅"


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between a5ed999 and 78afa65.
Files selected for processing (1)
  • e2e/testapp/app.go (2 hunks)
Files skipped from review due to trivial changes (1)
  • e2e/testapp/app.go

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between a5ed999 and 9db1a9d.
Files selected for processing (1)
  • e2e/testapp/app.go (2 hunks)
Files skipped from review due to trivial changes (1)
  • e2e/testapp/app.go

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1214 (9db1a9d) into main (a5ed999) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1214   +/-   ##
=======================================
  Coverage   48.61%   48.61%           
=======================================
  Files          77       77           
  Lines        4669     4669           
=======================================
  Hits         2270     2270           
  Misses       2236     2236           
  Partials      163      163           

@itsdevbear itsdevbear requested review from ocnc and calbera October 11, 2023 00:11
@itsdevbear itsdevbear merged commit 63d98bc into main Oct 11, 2023
@itsdevbear itsdevbear deleted the remove-ante branch October 11, 2023 00:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants