fix: Lint tests + fix e2e #1447
Conversation
…c414e` and it makes sense if you look at it sideways :D
|
Important Auto Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThe updates involve enhancing the analysis timeout and test execution in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (16)
contracts/go.modis excluded by:!**/*.modcontracts/go.sumis excluded by:!**/*.sumcosmos/go.modis excluded by:!**/*.modcosmos/go.sumis excluded by:!**/*.sume2e/localnet/go.modis excluded by:!**/*.mode2e/localnet/go.sumis excluded by:!**/*.sume2e/precompile/go.modis excluded by:!**/*.mode2e/precompile/go.sumis excluded by:!**/*.sume2e/testapp/go.modis excluded by:!**/*.mode2e/testapp/go.sumis excluded by:!**/*.sumeth/go.modis excluded by:!**/*.modeth/go.sumis excluded by:!**/*.sumgo.workis excluded by:!**/*.workgo.work.sumis excluded by:!**/*.sumlib/go.modis excluded by:!**/*.modlib/go.sumis excluded by:!**/*.sum
Files selected for processing (6)
- .golangci.yaml (3 hunks)
- build/scripts/main.mk (2 hunks)
- cosmos/x/evm/module.go (1 hunks)
- e2e/localnet/utils/utils.go (1 hunks)
- e2e/precompile/utils.go (1 hunks)
- e2e/testapp/app.go (2 hunks)
Files skipped from review due to trivial changes (4)
- .golangci.yaml
- cosmos/x/evm/module.go
- e2e/localnet/utils/utils.go
- e2e/testapp/app.go
Additional comments: 3
e2e/precompile/utils.go (1)
- 28-28: The
//nolint:revivedirective is used to bypass the linter for the import statement. This is not a typical practice and could be indicative of an underlying issue with the linter configuration or the import path.Please confirm that this is the only viable solution and consider investigating the root cause that necessitates this directive.
build/scripts/main.mk (2)
- 311-311: The
golangci_versionhas been updated tov1.55.2.Ensure that this version is compatible with the project's requirements and does not introduce any new issues.
- 325-325: The concurrency level for
golangci-fixhas been increased from8to64.This is a significant increase and could potentially overload some build environments. Verify that this level of concurrency is supported across all environments where the linting process will be executed.
|
need to restore the tools folder that was unintentional |
|
nah this just made the linter happy and did not make hive, e2e toolchain more happy. Lmk if any of it is interesting... |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1447 +/- ##
==========================================
+ Coverage 46.33% 46.47% +0.14%
==========================================
Files 89 89
Lines 5169 5149 -20
==========================================
- Hits 2395 2393 -2
+ Misses 2598 2580 -18
Partials 176 176
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (17)
build/tools/go.modis excluded by:!**/*.modbuild/tools/go.sumis excluded by:!**/*.sumcontracts/go.modis excluded by:!**/*.modcontracts/go.sumis excluded by:!**/*.sumcosmos/go.modis excluded by:!**/*.modcosmos/go.sumis excluded by:!**/*.sume2e/localnet/go.modis excluded by:!**/*.mode2e/localnet/go.sumis excluded by:!**/*.sume2e/precompile/go.modis excluded by:!**/*.mode2e/precompile/go.sumis excluded by:!**/*.sume2e/testapp/go.modis excluded by:!**/*.mode2e/testapp/go.sumis excluded by:!**/*.sumeth/go.modis excluded by:!**/*.modeth/go.sumis excluded by:!**/*.sumgo.work.sumis excluded by:!**/*.sumlib/go.modis excluded by:!**/*.modlib/go.sumis excluded by:!**/*.sum
Files selected for processing (1)
- .golangci.yaml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- .golangci.yaml
|
not really accomplishing the goal here I'm afraid. Putting this on draft. |
|
thanks @faddat trying some stuff out |
|
any time :D. |
This PR lints the polaris tests with the same standard as the rest of the repository.
This helped to find that SDK
d0c414ecommit seems to resolve some e2e issues.I think that this pr may pass e2e in ways others don't.
d0c414eand it makes sense if you look at it sideways :DSummary by CodeRabbit
Performance Improvements
Enhancements
Tooling Updates
v1.55.2.Codebase Refinements