Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

fix(e2e): fix broken precompile e2e tests and enable CI #906

Merged

Conversation

archbear
Copy link
Contributor

@archbear archbear commented Jul 17, 2023

erc20, gov and staking precompile tests still broken

add tests to ci

@itsdevbear itsdevbear closed this Jul 17, 2023
@linear
Copy link

linear bot commented Jul 17, 2023

@archbear archbear reopened this Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #906 (55c0a50) into main (3cc5220) will decrease coverage by 0.40%.
The diff coverage is 26.31%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
- Coverage   60.00%   59.61%   -0.40%     
==========================================
  Files         104      105       +1     
  Lines        4401     4432      +31     
==========================================
+ Hits         2641     2642       +1     
- Misses       1647     1676      +29     
- Partials      113      114       +1     
Files Changed Coverage Δ
cosmos/precompile/distribution/distribution.go 100.00% <ø> (ø)
cosmos/x/evm/plugins/precompile/log/attributes.go 68.29% <0.00%> (-3.51%) ⬇️
e2e/localnet/network/fixture.go 0.00% <0.00%> (ø)
e2e/localnet/network/node.go 0.00% <0.00%> (ø)
eth/core/precompile/stateful_container.go 100.00% <ø> (ø)
lib/utils/math.go 0.00% <0.00%> (ø)
cosmos/x/evm/plugins/state/events/manager.go 79.62% <25.00%> (-4.69%) ⬇️
eth/core/processor.go 77.19% <33.33%> (ø)
cosmos/x/evm/plugins/gas/plugin.go 73.80% <50.00%> (+3.35%) ⬆️
cosmos/precompile/governance/governance.go 86.66% <100.00%> (-0.57%) ⬇️
... and 3 more

@calbera calbera changed the title Calbera/plr 103 fix precompile e2e tests and enable in ci fix(e2e): fix broken precompile e2e tests and enable CI Jul 17, 2023
@calbera calbera marked this pull request as ready for review July 25, 2023 21:22
@calbera
Copy link
Contributor

calbera commented Jul 25, 2023

TODO: Disallow precompiles from accessing StateDB. Simple fix: remove GetStateDB from the PrecompileEVM interface.

@calbera calbera force-pushed the calbera/plr-103-fix-precompile-e2e-tests-and-enable-in-ci branch from 33e2a32 to 610a854 Compare July 25, 2023 22:24
@calbera calbera added the merge me daddy Trigger Beradozer to bulldoze the PR label Jul 26, 2023
@mergify mergify bot merged commit 04614dd into main Jul 26, 2023
18 checks passed
@mergify mergify bot deleted the calbera/plr-103-fix-precompile-e2e-tests-and-enable-in-ci branch July 26, 2023 19:07
@itsdevbear
Copy link
Member

lfg

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge me daddy Trigger Beradozer to bulldoze the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants