Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Automatic Checksums - Don't exclude everything when nothing is set to be excluded. #81

Conversation

Torqu3Wr3nch
Copy link
Contributor

Resolves Issue #80.

Swapped out !empty for isset on exclusion array. isset returns true for an empty string.

As the code was written, you were stuck with blanket/wildcard exclusions even when you didn't want to exclude anything at all.

I have tested in my development environment, but please feel free to double check.

Swapped out !empty for isset on exclusion array. isset returns true for an empty string.

As the code was written, you were stuck with blanket/wildcard exclusions even when you didn't want to exclude anything at all.
@Torqu3Wr3nch
Copy link
Contributor Author

Result of ps aux | grep inotify (with no excluded folders) and automatic file hashing enabled:

Before:
inotifywait -dsrqo /var/run/hash.pipe -e close_write --exclude ^/mnt/disk[0-9]+/(.*/|.*$|/) --format %w%f /mnt/disk1

After:
inotifywait -dsrqo /var/run/hash.pipe -e close_write --exclude '' --format %w%f /mnt/disk1

@bergware bergware merged commit 55eea92 into bergware:master Sep 1, 2023
@bergware
Copy link
Owner

bergware commented Sep 1, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants