Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duration to RoundRobinQueue #339

Closed
wants to merge 1 commit into from
Closed

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Nov 16, 2017

Tries to fix #319

@henrikbjorn
Copy link
Contributor

I suspect this violates the interface.

@ruudk
Copy link
Contributor Author

ruudk commented Nov 16, 2017

@sagikazarmark
Copy link
Contributor

I see two possible options:

  • add duration to the interface
  • make it a constructor argument

The second one is probably better from the abstraction point of view, but much harder to implement.

BTW that duration argument is never passed anywhere and the default value for drivers is 5 seconds anyway, so what's the point in adding it here now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make (long) polling of queues configurable
3 participants