Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cd.yml to cache npm dependencies #19

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

bernoussama
Copy link
Owner

@bernoussama bernoussama commented Aug 6, 2024

Summary by Sourcery

Update the continuous deployment workflow to cache npm dependencies, improving build efficiency by using actions/setup-node@v4.

Build:

  • Update cd.yml to cache npm dependencies using actions/setup-node@v4 with npm cache.

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
my-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 10:56pm

Copy link
Contributor

sourcery-ai bot commented Aug 6, 2024

Reviewer's Guide by Sourcery

This pull request updates the CI workflow configuration in .github/workflows/cd.yml to use the actions/setup-node@v4 action for setting up Node.js and caching npm dependencies. This change replaces the manual installation of npm and node using nvm with a more streamlined and efficient approach, ensuring a clean install of dependencies with npm ci.

File-Level Changes

Files Changes
.github/workflows/cd.yml Updated the CI workflow to use actions/setup-node@v4 for node setup and caching npm dependencies, simplifying the installation process and ensuring a clean install of dependencies.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

Deploying my-portfolio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1a027c8
Status: ✅  Deploy successful!
Preview URL: https://93afae4d.my-portfolio-8n6.pages.dev
Branch Preview URL: https://0ussamabernou-patch-3.my-portfolio-8n6.pages.dev

View logs

@bernoussama bernoussama merged commit 2ebd9d2 into main Aug 6, 2024
6 checks passed
@bernoussama bernoussama deleted the 0ussamaBernou-patch-3 branch August 6, 2024 22:56
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @0ussamaBernou - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant