Skip to content

add configuration to record and override on device #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add configuration to record and override on device #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
679ada0
add configuration to record and override on device
Rey-Castaneda Jun 23, 2022
2425280
v0.13.8-alpha.1
Jun 23, 2022
372406f
v0.13.8-alpha.2
Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"packages": [
"packages/*"
],
"version": "0.13.7"
"version": "0.13.8-alpha.2"
}
1 change: 1 addition & 0 deletions packages/batch/lib/device.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class Device {
}

if (this._configuration) { config = _.assign(config, this._configuration) }
if (record._configuration) { config = _.assign(config, record._configuration) }

const virtualDevice = new vdk.VirtualDevice(config)

Expand Down
4 changes: 3 additions & 1 deletion packages/batch/lib/record.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ const JSONUtil = require('@bespoken-sdk/shared/lib/json-util')
* @param {string} utterance The utterance to be sent to the voice experience being tested
* @param {Object.<string, string>} [expectedFields = {}] The expected values for the record
* @param {Object} [meta] Additional info about the record to be used in processing
* @param {Object} [config] configuration to override to device when needed
*/
constructor (utterance, expectedFields = {}, meta) {
constructor (utterance, expectedFields = {}, meta, config) {
this._utterance = utterance
this._utteranceRaw = utterance // Save off the original utterance in case we change it during processing
this._expectedFields = expectedFields
Expand All @@ -31,6 +32,7 @@ const JSONUtil = require('@bespoken-sdk/shared/lib/json-util')
this._locale = undefined
this._voiceID = undefined
this._rerun = false
this._configuration = config

/** @type {Object<string, any>} */
this._settings = {}
Expand Down
6 changes: 3 additions & 3 deletions packages/batch/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"bbt": "bin/bbt.js"
},
"dependencies": {
"@bespoken-sdk/shared": "^0.13.7",
"@bespoken-sdk/store": "^0.13.7",
"@bespoken-sdk/shared": "^0.13.8-alpha.2",
"@bespoken-sdk/store": "^0.13.8-alpha.2",
"axios": "^0.19.0",
"bespoken-tools": "^2.5.3",
"commander": "^5.1.0",
Expand Down Expand Up @@ -41,6 +41,6 @@
"test": "ava"
},
"types": "types/index.d.ts",
"version": "0.13.7",
"version": "0.13.8-alpha.2",
"gitHead": "1358c13969466dc2ca725041f046cceafb2122af"
}
6 changes: 3 additions & 3 deletions packages/collect/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
]
},
"dependencies": {
"@bespoken-sdk/nlp": "^0.13.7",
"@bespoken-sdk/shared": "^0.13.7",
"@bespoken-sdk/nlp": "^0.13.8-alpha.2",
"@bespoken-sdk/shared": "^0.13.8-alpha.2",
"axios": "^0.21.4",
"lodash": "^4.17.21"
},
Expand All @@ -23,6 +23,6 @@
"test": "ava"
},
"types": "types/index.d.ts",
"version": "0.13.7",
"version": "0.13.8-alpha.2",
"gitHead": "1358c13969466dc2ca725041f046cceafb2122af"
}
4 changes: 2 additions & 2 deletions packages/measure/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
]
},
"dependencies": {
"@bespoken-sdk/shared": "^0.13.7",
"@bespoken-sdk/shared": "^0.13.8-alpha.2",
"lodash": "^4.17.21"
},
"name": "@bespoken-sdk/measure",
Expand All @@ -17,7 +17,7 @@
"test": "ava"
},
"types": "types/index.d.ts",
"version": "0.13.7",
"version": "0.13.8-alpha.2",
"gitHead": "1358c13969466dc2ca725041f046cceafb2122af",
"devDependencies": {
"@types/node": "^16.10.1"
Expand Down
4 changes: 2 additions & 2 deletions packages/nlp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
]
},
"dependencies": {
"@bespoken-sdk/shared": "^0.13.7",
"@bespoken-sdk/shared": "^0.13.8-alpha.2",
"axios": "^0.21.4",
"lodash": "^4.17.21",
"memorystream": "^0.3.1",
Expand All @@ -27,6 +27,6 @@
"test": "ava"
},
"types": "types/index.d.ts",
"version": "0.13.7",
"version": "0.13.8-alpha.2",
"gitHead": "1358c13969466dc2ca725041f046cceafb2122af"
}
2 changes: 1 addition & 1 deletion packages/shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"scripts": {
"test": "ava"
},
"version": "0.13.7",
"version": "0.13.8-alpha.2",
"devDependencies": {
"@types/node": "^16.10.1"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/store/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
]
},
"dependencies": {
"@bespoken-sdk/shared": "^0.13.7",
"@bespoken-sdk/shared": "^0.13.8-alpha.2",
"axios": "^0.21.4",
"lodash": "^4.17.21"
},
Expand All @@ -17,7 +17,7 @@
"scripts": {
"test": "ava"
},
"version": "0.13.7",
"version": "0.13.8-alpha.2",
"gitHead": "1358c13969466dc2ca725041f046cceafb2122af",
"devDependencies": {
"@types/node": "^16.10.1"
Expand Down