Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

209 demo code #233

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

209 demo code #233

wants to merge 7 commits into from

Conversation

ldavies99
Copy link

This branch resolves #209

@ldavies99 ldavies99 self-assigned this Jun 28, 2024
@ldavies99 ldavies99 added the documentation 📖 Improvements or additions to documentation label Jun 28, 2024
@ldavies99 ldavies99 requested a review from danmilne1 June 28, 2024 10:38
Copy link
Collaborator

@rowanhemsi rowanhemsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition to the set of examples. Unfortunately when I run it and try to open the spreadsheet, Excel is giving me a warning and says it needs to try to repair the document. Do you know what is causing this?

Comment on lines +52 to +54
iris_table = gpt.GPTable(table=labour_market_data, **kwargs)

sheets = {"sheet 1a": iris_table}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you rename iris_table

Comment on lines +18 to +19
labour_market_data.dropna(axis=0, how="all", inplace=True)
labour_market_data.dropna(axis=1, how="all", inplace=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are using this as a training example now, please can you add a comment to explain why we're doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create code to demonstrate replication of the ONS good standards example spreadsheet
2 participants