Don't lookup empty email when canonicalizing #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Email addresses are optional. Very bad things happen if we treat all users who have no email address as the same user. Example: 1. $RT::Config::ValidateUserEmailAddresses is enabled (as per default) 2. There exists user "A" whose EmailAddress is empty. 3. There exists user "B" whose EmailAddress is '[email protected]'. 4. User A is merged into User B. Suppose RT::Interface::Web::AttemptExternalAuth() calls $UserObj->Create(Name => ..., Gecos => ...); The call will fail, since the call gets canonicalized to $UserObj->Create( Name => ..., Gecos => ..., EmailAddress => '[email protected]' ); and RT::User::ValidateUserEmailAddress() will reject it with an "Email address in use" error. This commit changes CanonicalizeEmailAddress() so that it does not try to rewrite an empty address. In addition, a conditional has been rewritten to avoid a double negative and an excessively long line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #2