formatting setup #3196
formatting setup #3196
Conversation
chmelevskij
force-pushed
the
chore/add-prettier
branch
from
e4f2a86 to
6984a78
Compare
| @@ -20,7 +20,8 @@ cordova/bundle.keystore | |||
| .DS_store | |||
|
|
|||
| # artefacts for Visual Studio Code | |||
| /.vscode/ | |||
| .vscode/* | |||
| !.vscode/extensions.json | |||
There was a problem hiding this comment.
@McGiverGim Adding this so that we can recommend some extensions as well as having the commit hooks.
There was a problem hiding this comment.
Ok, I'm not too sure if this will work if the user has its own file.
| "no-trailing-spaces": "error", | ||
| "eol-last": "error", |
There was a problem hiding this comment.
Why are these removed? Maybe they are included in other part?
There was a problem hiding this comment.
Exactly, formatter (pretier) is handling these kind of things better.
linter (eslint) is better for enforcing/discouraging specific patterns.
chmelevskij
force-pushed
the
chore/add-prettier
branch
from
6984a78 to
ad05ecc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week. |
|
Closing this as there seems to be no traction |
|
@chmelevskij sorry we simply did not get time for this. |
|
Lol, just saw you re-opened this 🫣 |
|
Yes this would be helpful 🤞 |
|
But needs a rebase 🙈 |
|
|
This would be great! I would migrate to Prettier formatting. |
* add pre-commit hooks to lint stage files * prettier setup * eslint setup
haslinghuis
force-pushed
the
chore/add-prettier
branch
from
ad05ecc to
7db4d60
Compare
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
There is a separate PR #3197 which actually applies all these changes. Keeping separate for clarity.