-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.5 filter defaults #429
4.5 filter defaults #429
Conversation
|
||
set acc_lpf_hz = 25 | ||
|
||
set dshot_bidir = OFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer default for all targets as more will be enabled by default on flash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer default for all targets as more will be enabled by default on flash.
this file is mainly to be used with other presets as a wiping step. Some other presets rely on this to be false. They turn it ON if needed or selected by the user in the option. So making it TRUE by default in this file will break some presets.
If someone uses this file as a standalone preset in configurator... oh well... :) he will have rpm filters OFF :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes just asking - not asking to enable - but maybe not use it.
Reliance for other presets should not be an issue. If it's on already it does not fail when asking again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes just asking - not asking to enable - but maybe not use it.
Reliance for other presets should not be an issue. If it's on already it does not fail when asking again.
we can remove it from here after fixing other presets. Need to go through them one-by one and see which ones are relying on this one be OFF by default and add set dshot_bidir = OFF
there.
But let's make it the last step, so we don't make a mess. First need to copy all presets straight up without modifications. And then individually go one by one with your proposal.
what are PG groups? We recently discussed with UAV Tech about how to approach 4.5 presets. You wanted to add 4.5 firmware naming to the 4.4 preset to avoid repetition. Does this mean that we are changing tack now to discrete 4.5 presets? |
yes, i will take care of all that, authors don't need to do anything, except if they need some values to be adjusted. I will prepare new defaults, and will copy over presets from 4.4 to 4.5. |
This PR is the first PR in the sequence of transferring tune/filter presets for 4.5.
My dream about full transfer defaults to PG groups can't become true yet.
The main reason that
PG_GYRO_CONFIG
includes some stuff that's hardware/user related.And that
PG_PID_PROFILE
contains d-term filters.So for 4.5 filters defaults can only use:
defaults group_id 554 nosave # PG_DYN_NOTCH_CONFIG
defaults group_id 544 nosave # PG_RPM_FILTER_CONFIG
which I did here.
the rest of the parameters should be listed explicitly.
I listed them in the order they appear in CLI, that's easier to maintain.
The next PRs will be: