Modification de 'delete_roles!'

betagouv · Oct 16, 2024 · 22a6720 · 22a6720
1 parent 9203ec6
commit 22a6720
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/app/controllers/users/omniauth_callbacks_controller.rb b/app/controllers/users/omniauth_callbacks_controller.rb
@@ -133,15 +133,9 @@ def delete_roles!
       combined_establishments = establishments_authorised + establishments_in_responsibility
 
       # Ne garde que les élements distincts entre les rôles d'APLyPro et ceux de KeyCloak.
-      @user.establishments
-           .reject { |establishment| combined_establishments.include?(establishment) }
-           .each { |establishment| delete_role(establishment) }
-    end
-
-    def delete_role(establishment)
-      EstablishmentUserRole
-        .find_by(user: @user, establishment: establishment)
-        .destroy
+      EstablishmentUserRole.where(user: @user).find_each do |access|
+        access.destroy unless combined_establishments.includes(access.establishment)
+      end
     end
 
     def log_user_in!