asp: clarify the filename attribute and fix file_saved? for payments #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeSuisUnCaillou
approved these changes
Apr 5, 2024
| @@ -4,13 +4,13 @@ module ASP | |||
| class FileHandler | |||
| include Errors | |||
|
|
|||
| attr_reader :filepath, :filename | |||
| attr_reader :filepath, :filename_noext | |||
There was a problem hiding this comment.
A quoi sert ce renommage, j'ai pas compris 🤔
ça veut dire quoi "noext" ?
There was a problem hiding this comment.
Aaah, "no extension" ok, j'ai.
C'est pas ouf les abréviations dans les noms de variable. Je préfèrerait un truc plus explicite comme filename_without_extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #682