pfmp: fix the day count validation logic #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freesteph
force-pushed
the
fix/pfmp-day-count-validation
branch
from
d761dcb
to
4012ef6
Compare
JeSuisUnCaillou
approved these changes
Apr 5, 2024
spec/models/pfmp_spec.rb
Outdated
Comment on lines
55
to
56
| start_date: start, | ||
| end_date: start.end_of_week(:saturday) |
There was a problem hiding this comment.
A la première lecture, j'ai eu l'impression que on allait du lundi au samedi avec cette syntaxe.
Je préfèrerait qu'on ajoute un nombre de jours explicite pour le test :
end_date: start + 4.daysThere was a problem hiding this comment.
j'entends (moi aussi ça me dérange) mais je trouve tout aussi confus que lundi + 4 jours perso 😅 mais bon ça l'est peut-être moins que le saturday
There was a problem hiding this comment.
A full week means 5 days which wasn't allowed before.
freesteph
force-pushed
the
fix/pfmp-day-count-validation
branch
from
4012ef6
to
ac17c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #686.