Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SchoolYear refacto part 2 (UI changes) #947

Merged
merged 5 commits into from
Jul 12, 2024
Merged

SchoolYear refacto part 2 (UI changes) #947

merged 5 commits into from
Jul 12, 2024

Conversation

tnicolas1
Copy link
Collaborator

No description provided.

@tnicolas1 tnicolas1 requested a review from JeSuisUnCaillou May 30, 2024 08:25
@tnicolas1 tnicolas1 linked an issue May 30, 2024 that may be closed by this pull request
Gestion de l'année scolaire #944
Closed
7 tasks
@tnicolas1 tnicolas1 requested review from pskl and removed request for JeSuisUnCaillou May 30, 2024 09:05
pskl
pskl reviewed May 30, 2024
View reviewed changes
app/models/classe.rb Outdated Show resolved Hide resolved
pskl

This comment was marked as resolved.

Sign in to view

@pskl pskl changed the title Modifier les tables en base de données WIP: SchoolYear refacto May 30, 2024
pskl
pskl reviewed May 30, 2024
View reviewed changes
db/school_year_seeder.rb Outdated Show resolved Hide resolved
@tnicolas1 tnicolas1 force-pushed the feat/school-year branch 5 times, most recently from 1969ec8 to cdedb0d Compare May 31, 2024 13:27
@JeSuisUnCaillou JeSuisUnCaillou marked this pull request as ready for review June 3, 2024 08:35
JeSuisUnCaillou
JeSuisUnCaillou reviewed Jun 3, 2024
View reviewed changes
app/models/concerns/pfmp_amount_calculator.rb Outdated Show resolved Hide resolved
app/models/student/mappers/base.rb Outdated Show resolved Hide resolved
app/models/school_year.rb Outdated Show resolved Hide resolved
app/services/updaters/student_schoolings_updater.rb Outdated Show resolved Hide resolved
db/migrate/20240529115713_create_school_year.rb Outdated Show resolved Hide resolved
db/school_year_seeder.rb Outdated Show resolved Hide resolved
db/seeds.rb Outdated Show resolved Hide resolved
db/wage_seeder.rb Outdated Show resolved Hide resolved
features/step_definitions/perdir_steps.rb Outdated Show resolved Hide resolved
spec/factories/mefs.rb Outdated Show resolved Hide resolved
@tnicolas1 tnicolas1 force-pushed the feat/school-year branch 9 times, most recently from 87cd415 to 257ba90 Compare June 6, 2024 12:30
pskl
pskl reviewed Jun 6, 2024
View reviewed changes
db/school_year_seeder.rb Outdated Show resolved Hide resolved
@tnicolas1 tnicolas1 force-pushed the feat/school-year branch 8 times, most recently from d80e21a to 363451f Compare July 4, 2024 10:00
pskl
pskl reviewed Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@pskl pskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beau progrès, bel ouvrage 🥇

Je t'ai laissé des pistes d'améliorations possibles pour atteindre des sommets toujours plus hauts.

app/controllers/application_controller.rb Show resolved Hide resolved
app/controllers/classes_controller.rb Outdated Show resolved Hide resolved
app/controllers/classes_controller.rb Outdated Show resolved Hide resolved
app/controllers/classes_controller.rb Outdated Show resolved Hide resolved
app/controllers/classes_controller.rb Outdated Show resolved Hide resolved
app/helpers/home_helper.rb Outdated Show resolved Hide resolved
app/views/home/_home_timeline.html.haml Show resolved Hide resolved
app/views/shared/_etab_banner.html.haml Show resolved Hide resolved
features/changement_annee.feature Show resolved Hide resolved
spec/requests/classes_controller_spec.rb Outdated Show resolved Hide resolved
@tnicolas1 tnicolas1 force-pushed the feat/school-year branch 10 times, most recently from 03b38cd to ac0684e Compare July 8, 2024 09:55
@pskl pskl changed the title WIP: SchoolYear refacto part 2 (UI changes) SchoolYear refacto part 2 (UI changes) Jul 8, 2024
@pskl pskl merged commit a483da3 into main Jul 12, 2024
5 checks passed
@pskl pskl deleted the feat/school-year branch July 12, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeSuisUnCaillou JeSuisUnCaillou JeSuisUnCaillou left review comments

@freesteph freesteph freesteph left review comments

@pskl pskl pskl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gestion de l'année scolaire
4 participants
@tnicolas1 @freesteph @pskl @JeSuisUnCaillou