Brevo update contacts : Commencer par la création des nouveaux contacts et ensuite MAJ des contacts existants #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e peut pas être updaté car un des contact n existe pas
added 3 commits
October 28, 2024 17:46
qloridant
changed the title
qloridant
changed the title
added 2 commits
October 31, 2024 12:03
raphodn
approved these changes
Oct 31, 2024
| """ | ||
| new_user = UserFactory.create() | ||
| batch_update_mock.side_effect = Exception("Error !") | ||
| # @mock.patch("macantine.brevo.contacts_api_instance.create_contact") |
There was a problem hiding this comment.
à supprimer ? ou il y a un soucis avec ce test ?
Co-authored-by: Raphaël Odini <[email protected]>
Co-authored-by: Raphaël Odini <[email protected]>
…:betagouv/ma-cantine into 4493-problme-avec-la-configuration-brevo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nous mettons à jour régulièrement les contact Brevo en filtrant nos contacts par le champ
last_brevo_update. Il existe deux cas :La mise à jour se fait par Batch via l'API de Brevo. L'API de Brevo fait planter tout le batch en cas d'erreur (cf cette issue). Or un contact non existant est une erreur.
Les contacts non existants sont crées dans un second temps.
Solution #1 : Cette erreur n'est pas grave. Il faut donc baisser le niveau de logging.
Solution #2 : D'abord créer les contacts non existants puis MAJ par batch des contacts existants