Fix deploy functions 13

bettersg · Nov 27, 2024 · 5a4f321 · 5a4f321
1 parent 163b3bd
commit 5a4f321
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/deploy_functions.yml b/.github/workflows/deploy_functions.yml
@@ -41,8 +41,6 @@ jobs:
       # Step 6: deploy functions
       - name: Deploy functions
         working-directory: backend
-        run: |
-          export GOOGLE_APPLICATION_CREDENTIALS=$HOME/gcloud.json
-          echo "GOOGLE_APPLICATION_CREDENTIALS=$GOOGLE_APPLICATION_CREDENTIALS"
-          cat $GOOGLE_APPLICATION_CREDENTIALS
-          npx firebase-tools deploy --only functions --debug --token "${{ secrets.FIREBASE_TOKEN_SCHEMESSG_V3_DEV }}"
+        env:
+          GOOGLE_APPLICATION_CREDENTIALS: $HOME/gcloud.json
+        run: npx firebase-tools deploy --only functions --debug --token "${{ secrets.FIREBASE_TOKEN_SCHEMESSG_V3_DEV }}"
diff --git a/backend/functions/fb_manager/firebaseManager.py b/backend/functions/fb_manager/firebaseManager.py
@@ -30,6 +30,10 @@ def _initialize_app(self):
             # Replace newlines in private key
             # private_key = os.getenv("FB_PRIVATE_KEY").replace("\\n", "\n")
             path_to_creds = os.getenv("GOOGLE_APPLICATION_CREDENTIALS")
+
+            if not path_to_creds or not os.path.exists(path_to_creds):
+                raise ValueError(f"Invalid certificate path: {path_to_creds}. Make sure GOOGLE_APPLICATION_CREDENTIALS is set properly.")
+
             cred = credentials.Certificate(path_to_creds)  # Adjust path as needed
 
             # cred = credentials.Certificate(