Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feedback firebase function #57

Merged
merged 5 commits into from
Nov 24, 2024
Merged

Add feedback firebase function #57

merged 5 commits into from
Nov 24, 2024

Conversation

sparkli94
Copy link
Collaborator

No description provided.

@sparkli94 sparkli94 self-assigned this Nov 12, 2024
@sparkli94 sparkli94 linked an issue Nov 12, 2024 that may be closed by this pull request
Firebase function - User Feedback #52
Closed
@sparkli94
Copy link
Collaborator Author

Not sure why the checks have failed...

yevkim
yevkim reviewed Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@yevkim yevkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you compare with firebase_func_search on their implementation and use of singleton pattern just to align it's the same approach.

backend/functions/feedback/feedback.py Outdated Show resolved Hide resolved
backend/functions/feedback/feedback.py Outdated Show resolved Hide resolved
@sparkli94
Corrected feedback post request to the correct collection, added user…
b143a46 
…Name and userEmail as per Notion doc, used singleton method however fb_manager does not exist in this branch
@sparkli94
Copy link
Collaborator Author

sparkli94 commented Nov 16, 2024 •
edited
Loading

Can you compare with firebase_func_search on their implementation and use of singleton pattern just to align it's the same approach.

Certainly, I've used the same singleton approach as in firebase_func_search using the from fb_manager.firebaseManager import FirebaseManager logic. However I haven't put their stuff into this branch. I'm not entirely sure if I should be creating a pull request into firebase_func_search or stg? Currently it's straight into stg, but this means I don't have fb_manager.firebaseManager available in this branch. I think that's why my pipeline is failing.

@yevkim yevkim requested a review from longwind48 November 20, 2024 17:46
@yevkim yevkim merged commit d2cae29 into stg Nov 24, 2024
1 check failed
@yevkim yevkim deleted the feedback branch November 24, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevkim yevkim yevkim left review comments

@rebeccacxy rebeccacxy rebeccacxy approved these changes

@longwind48 longwind48 Awaiting requested review from longwind48

Assignees

@sparkli94 sparkli94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firebase function - User Feedback
3 participants
@sparkli94 @yevkim @rebeccacxy