Merge pull request #343 from bettersg/feat/add-absolute-thresholds

added absolute thresholds
bettersg · Jun 12, 2024 · c6771af · c6771af
2 parents 41456b0 + ee50bbc
commit c6771af
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/functions/src/definitions/common/parameters/thresholds.json b/functions/src/definitions/common/parameters/thresholds.json
@@ -2,6 +2,9 @@
   "endVote": 0.5,
   "endVoteSus": 0.2,
   "endVoteUnsure": 0.8,
+  "endVoteAbsolute": 10,
+  "endVoteSusAbsolute": 4,
+  "endVoteUnsureAbsolute": 16,
   "startVote": 1,
   "isSpam": 0.5,
   "isLegitimate": 0.5,

diff --git a/functions/src/definitions/eventHandlers/onVoteRequestUpdate.ts b/functions/src/definitions/eventHandlers/onVoteRequestUpdate.ts
@@ -109,11 +109,23 @@ const onVoteRequestUpdateV2 = onDocumentUpdated(
         unsureCount > thresholds.isUnsure * validResponsesCount
       const isAssessed =
         (isUnsure &&
-          validResponsesCount > thresholds.endVoteUnsure * factCheckerCount) ||
+          validResponsesCount >
+            Math.min(
+              thresholds.endVoteUnsure * factCheckerCount,
+              thresholds.endVoteSusAbsolute //16
+            )) ||
         (!isUnsure &&
-          validResponsesCount > thresholds.endVote * factCheckerCount) ||
+          validResponsesCount >
+            Math.min(
+              thresholds.endVote * factCheckerCount,
+              thresholds.endVoteAbsolute //10
+            )) ||
         (isSus &&
-          validResponsesCount > thresholds.endVoteSus * factCheckerCount)
+          validResponsesCount >
+            Math.min(
+              thresholds.endVoteSus * factCheckerCount,
+              thresholds.endVoteSusAbsolute //4
+            ))
 
       //set primaryCategory
       let primaryCategory