Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkers App #168

Merged
merged 14 commits into from
Oct 14, 2023
Merged

Checkers App #168

merged 14 commits into from
Oct 14, 2023

Conversation

sarge1989
Copy link
Collaborator

@sarge1989 sarge1989 commented Sep 30, 2023

Big change to repository structure to accommodate the Telegram webapp stuff too!

More details at https://www.notion.so/better/Repo-Instructions-8840592b23d0442ba062209f9036f634, including references to the authentication mechanisms suggested by telegram.

Notes:

  • Using React + Vite + Firebase Hosting together.
    • Using the firebase.json rewrites to send the routes to the api and authentication handlers as per here
    • Need a look through to see if I'm implementing hot reload in dev in the right way (see npm build:watch in the checkers-app folder)
  • None of the telegram functions are implemented yet
  • Skeleton of the telegram webapp is there, I've implemented the authentication stuff using firebase auth. Can take a look, it should work.

@sarge1989 sarge1989 marked this pull request as ready for review September 30, 2023 23:55
}

if (userId) {
const userSnap = await db.collection("factCheckers").doc("6591807628").get()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that mock data is now tagged to the callers phone number, consider changing "65..." to an ENV value

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 6ec2eb4

@sarge1989 sarge1989 merged commit 8f5525b into develop Oct 14, 2023
1 check passed
@sarge1989 sarge1989 deleted the checkers-app branch October 14, 2023 03:49
@sarge1989 sarge1989 mentioned this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants