Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove interim feedback and migrated Telegram handler to pubsub #194

Merged
merged 14 commits into from
Nov 9, 2023
Merged

Remove interim feedback and migrated Telegram handler to pubsub #194

merged 14 commits into from
Nov 9, 2023

Conversation

sarge1989
Copy link
Collaborator

@sarge1989 sarge1989 commented Nov 5, 2023 •
edited
Loading

Issues

Summary

  • Simple change to remove step that asked for feedback upon sending interim reply. Reduces number of messages and code complexity
  • Made telegram handlers async

@sarge1989
Copy link
Collaborator Author

Remember to change translate google sheet and remove user messages when merged into develop.

@sarge1989 sarge1989 changed the title Remove interim feedback Remove interim feedback and migrated Telegram handler to pubsub Nov 5, 2023
@sarge1989 sarge1989 requested a review from stonefruit November 7, 2023 02:41
@sarge1989 sarge1989 merged commit eff5c52 into develop Nov 9, 2023
1 check passed
@sarge1989 sarge1989 deleted the feat/remove-interim-feedback branch November 9, 2023 14:25
@sarge1989 sarge1989 mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonefruit stonefruit stonefruit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of interim reply feedback Update telegram handler to put in queue instead
3 participants
@sarge1989 @stonefruit @bwsarge