anonymisation of messages after a legitimate vote #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonefruit
reviewed
Nov 19, 2023
| if (env === "SIT") { | ||
| return message | ||
| } | ||
| let returnMessage = message.replace(/\u00a0/g, " ") | ||
| try { | ||
| const anonymisationHyperparameters = hyperparameters?.anonymisation | ||
| let anonymisationHyperparameters = isComplex |
There was a problem hiding this comment.
for hyperparameters?.complexAnonymisation, would it be useful to fall back to the simple version if not present?
There was a problem hiding this comment.
I think not necessary! Cos business wise, we rather not anonymize at all if there are issues, as opposed to anonymize and lose info for the checkers.
stonefruit
approved these changes
Nov 19, 2023
sarge1989
deleted the
185-anonymise-messages-fully-after-a-legitimate-outcome
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Summary