Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Voting Tag Chart #506

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

keenlim
Copy link
Collaborator

@keenlim keenlim commented Nov 10, 2024

Pull Request to Deploy to UAT

Issue Reference

Example:
Resolves #[450]

Description

Provide a voting tag chart result to show the results of the voted tags.

A clear and concise description of what changes were made to address the issue.

Implementation

  1. Added a VotingTagChart component in VotingTagChart.tsx
  2. Uses recharts library to create the Pie chart to visualised the tags voted.

Testing

No tests written

Additional Notes

NIL


Checklist

  • I have linked the issue above using closing keywords if this PR resolves the issue
  • I have provided a description and implementation details
  • I have tested the changes and ensured that they work

@keenlim keenlim requested a review from sarge1989 November 10, 2024 08:25
@keenlim keenlim self-assigned this Nov 10, 2024
@keenlim keenlim linked an issue Nov 10, 2024 that may be closed by this pull request
@sarge1989
Copy link
Collaborator

a few changes needed!

  • there should be one chart per tag
  • each chart should show those who tagged it vs those who didnt, for that vote

so for e.g., if for a certain one message, got 10 ppl submitted votes, and 3 tagged it as generated. 5 tagged as incorrect

so it should show 2 charts

one showing 3-7
one showing 5-5

Let me know if unclear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add charts for each tag in the results charts in the checkers-app
2 participants