#514 Implement voting on Community note #516

keenlim · 2024-12-04T14:12:00Z

Pull Request to Deploy to UAT

##Issue Reference

Example:
Resolves #[514]

Description

Implementing voting on community note and showing the results in terms of a pie chart.

Implementation

Frontend Changes: Voting frontend interface becomes an accordion form, where users are forced to select a community note category before they are able to select the messages category. To submit the form, users will need to select both the community note category and the messages category.
Backend Changes: When users submit the selection of both community note category and the messages category, it will be patched onto the database and count the number of community note category users select.
Results Page: A pie chart of the results that counts the number of community note category will be shown on the results page.

Testing

Additional Notes

Checklist

I have linked the issue above using closing keywords if this PR resolves the issue
I have provided a description and implementation details
I have tested the changes and ensured that they work

sarge1989 · 2024-12-04T22:39:37Z

functions/src/definitions/api/handlers/patchVoteRequest.ts

@@ -21,6 +21,7 @@ const patchVoteRequestHandler = async (req: Request, res: Response) => {
  //confirm category in body
  const { category, communityNoteCategory, truthScore, reasoning, tags } =
    req.body as updateVoteRequest
+  console.log(communityNoteCategory)


Can look thru and replace console.log with logger.log from the firebase logger?

Other files as well

sarge1989

Looks generally good but comments inline in code!

The key feature addition needed is to show the links hahah.

But since you're so fast, can u help me with the following implementation as well:

If more than 50% of the votes cast are "unacceptable", AND more than 50% of the checkers have voted, set the CommunityNote.downvoted field in Message to true
When that happens, send a correction note to each user that received the community note, replying to the community note in WhatsApp. This means that we should add a communityNoteMessageId field to instances so we can track the messageId to reply to via WhatsApp.
The exact wording of the correction note can be set later, but it should be something like:

Sorry, our checkers have determined that the AI got that wrong!

{today's category-based reply reply}

U can add a row in the translations file for this new response hahah, just put whatever u think makes sense first, I'll clean up the words later.

Also, make sure that everything works end to end if the community note generation fails and sends u null too k. To check that, go to functions\src\definitions\common\machineLearningServer\operations.ts, in getCommunityNote function just throw an error instead of returning the this is a test. Basically, the behaviour should be exactly the same as today if this occurs.

sarge1989 · 2024-12-04T22:39:52Z

functions/src/definitions/api/handlers/patchVoteRequest.ts

@@ -21,6 +21,7 @@ const patchVoteRequestHandler = async (req: Request, res: Response) => {
  //confirm category in body
  const { category, communityNoteCategory, truthScore, reasoning, tags } =
    req.body as updateVoteRequest
+  console.log(communityNoteCategory)


Other files as well

sarge1989 · 2024-12-04T22:48:16Z

checkers-app/src/components/myvotes/CommunityCard.tsx

+ return parts;
+ }
+
+export default function CommunityCard(prop: PropType){


Can change the "CommunityCard" name to "CommunityNoteCard"? Same for categories etc. I'm always very concerned about getting the nomenclature meaningful so ppl can easily understand the code

sarge1989 · 2024-12-04T22:48:58Z

checkers-app/src/components/vote/OldVoteCategories.tsx

Not used liao right this one?

sarge1989 · 2024-12-04T22:49:43Z

functions/src/definitions/api/handlers/patchVoteRequest.ts

@@ -21,6 +21,7 @@ const patchVoteRequestHandler = async (req: Request, res: Response) => {
  //confirm category in body
  const { category, communityNoteCategory, truthScore, reasoning, tags } =
    req.body as updateVoteRequest
+  console.log(communityNoteCategory)


Can remove all the console.log in the code. If want, use the firebase logging functionality logger.log

sarge1989 · 2024-12-04T22:50:45Z

checkers-app/src/components/myvotes/CommunityCard.tsx

Can we have a section to show the links too? These will be the links identified by the GenAI system. Will help the checkers review the links to make sure the note is congruent with the link

sarge1989 · 2024-12-04T22:51:16Z

functions/src/definitions/eventHandlers/onVoteRequestUpdate.ts

@@ -308,6 +311,10 @@ async function updateCounts(
  const currentCategory = after.category
  let previousScore = before.truthScore
  let currentScore = after.truthScore
+  const previousCommunityCategory = before.communityNoteCategory
+  console.log(previousCommunityCategory)


Remove the console.logs here and other files hahah

merge from feat/checkmate-v2

sarge1989 · 2024-12-11T23:34:20Z

functions/src/definitions/eventHandlers/onVoteRequestUpdate.ts

@@ -162,6 +168,14 @@ const onVoteRequestUpdateV2 = onDocumentUpdated(
              thresholds.endVoteAbsolute //10
            ))

+      const isAssessedUnacceptable =


I added this, to only switch downvoted to true if 50% have voted

sarge1989 · 2024-12-11T23:34:30Z

functions/src/definitions/eventHandlers/onVoteRequestUpdate.ts

@@ -225,6 +239,11 @@ const onVoteRequestUpdateV2 = onDocumentUpdated(
        }
      }

+      if (isAssessedUnacceptable) {


Changed this as well

sarge1989 · 2024-12-11T23:36:05Z

functions/src/definitions/eventHandlers/onMessageUpdate.ts

+      }
+    }
+
+    if (


Only reply community note instances under 2 circumstances

downvoted tag switched to true and messageData is assessed

isAssessed tag switched to true and pendingCorrection tag (new thing I added) is true

Also means there's a case where we need to switch pendingCorrection to true if downvoted tag switched to true but messageData not yet assessed

sarge1989 · 2024-12-11T23:39:37Z

functions/src/definitions/common/responseUtils.ts

@@ -1155,7 +1161,14 @@ async function respondToInstance(
          await userSnap.ref.update({
            numSubmissionsRemaining: FieldValue.increment(1),
          })
-          await sendTextMessage("user", from, responseText, data.id)
+          if (communityNote.downvoted) {


These changes shouldn't be made in respondToInstance, it should be a separate function imo. Because respondToInstance is also called whenever subsequent users send in new instances, even when they didn't get the community note in the first place. In that case, we don't want to have this correction statement. Either implement another specific function like correctCommunityNote (off my mind that's preferred), but feel free to let me know if you disagree, or otherwise we need to check isCommunityNoteSent for this instance.

Also because the logic needs to set communityNote.pendingCorrection to false.

If we using another function, can think about whether it makes sense to split out the line 1065 onwards of respondToInstance into another function because it'll be repeated in respondToInstance and correctCommunityNote.

sarge1989 · 2024-12-11T23:48:22Z

functions/src/definitions/eventHandlers/onVoteRequestUpdate.ts

@@ -52,6 +52,7 @@ const onVoteRequestUpdateV2 = onDocumentUpdated(
    const messageSnap = await messageRef.get()
    const beforeTags = preChangeData?.tags ?? {}
    const afterTags = postChangeData?.tags ?? {}
+    const currentCommunityCategory = postChangeData.communityNoteCategory


Rename this currentCommunityNoteCategory pls! Paiseh for being pendantic.

keenlim added 3 commits December 4, 2024 12:21

Feature: New Voting System

956efd4

Merge branch 'feat/checkmate-v2' into feat/checkmate-v2-keen

3597ac1

implement voting results

27f08fc

keenlim requested a review from sarge1989 December 4, 2024 14:12

keenlim self-assigned this Dec 4, 2024

sarge1989 reviewed Dec 4, 2024

View reviewed changes

keenlim and others added 6 commits December 11, 2024 10:02

Merge branch 'feat/checkmate-v2' into feat/checkmate-v2-keen

294165e

merge from feat/checkmate-v2

Links section and minor changes

b376ea6

sending of correction note to users

5c126bf

Minor changes

906572e

Minor changes

2a7ceb0

key corrections implemented

5125300

sarge1989 reviewed Dec 11, 2024

View reviewed changes

keenlim and others added 4 commits December 14, 2024 12:18

CommunityNote Correction Function

4d3bdb8

updated handling of correction

6664482

Merge branch 'feat/checkmate-v2' into feat/checkmate-v2-keen

abce963

updated handling

d6405eb

sarge1989 merged commit 9c5d69d into feat/checkmate-v2 Dec 14, 2024
1 check failed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#514 Implement voting on Community note #516

#514 Implement voting on Community note #516

keenlim commented Dec 4, 2024 •

edited by nghuiling

Loading

sarge1989 Dec 4, 2024

sarge1989 Dec 4, 2024

sarge1989 left a comment •

edited

Loading

sarge1989 Dec 4, 2024

sarge1989 Dec 4, 2024

sarge1989 Dec 4, 2024

sarge1989 Dec 4, 2024

sarge1989 Dec 4, 2024

sarge1989 Dec 4, 2024

sarge1989 Dec 11, 2024

sarge1989 Dec 11, 2024

sarge1989 Dec 11, 2024

sarge1989 Dec 11, 2024 •

edited

Loading

sarge1989 Dec 11, 2024

sarge1989 Dec 11, 2024

sarge1989 Dec 11, 2024

+                    }
+                  }
+                  if (

#514 Implement voting on Community note #516

#514 Implement voting on Community note #516

Conversation

keenlim commented Dec 4, 2024 • edited by nghuiling Loading

Pull Request to Deploy to UAT

Description

Implementation

Testing

Additional Notes

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarge1989 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarge1989 Dec 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keenlim commented Dec 4, 2024 •

edited by nghuiling

Loading

sarge1989 left a comment •

edited

Loading

sarge1989 Dec 11, 2024 •

edited

Loading