time field highlighting when picked (for always open time picker) #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time field highlighting when picked, useful for time pickers that stay open.
| @@ -628,6 +630,15 @@ function calendar (calendarOptions) { | |||
| if (!classes.contains(target, o.styles.timeOption)) { | |||
| return; | |||
| } | |||
| if (!classes.contains(target, o.styles.selectedTime)) { | |||
|
Make the changes in the comments and please add:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is setting the 'selected' class to the HTML element picked, which is useful when the time picker stays always open and you want to provide visual feedback of the current choice made, similar to the calendar.
ideally this would be accompanied by a time setting, eg. timeAutoClose: 'never', which would avoid toggling the visibility of the picker. Currently, the workaround is to use CSS to force the time picker parent to always show. It works, but less elegantly.
this is my first pull req - feel free to implement properly, or even
drop it altogether ;-)