Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource Sharing Tax Mod: Prevent upgrading allied mex/geos. No longer disables unit sharing completely, and can buy t2 con through Unit Market #4010
base: master
Are you sure you want to change the base?
Resource Sharing Tax Mod: Prevent upgrading allied mex/geos. No longer disables unit sharing completely, and can buy t2 con through Unit Market #4010
Changes from 3 commits
a02b902
dc61530
6c325ce
8d84a20
bdeb49a
b61d952
7d43f2f
b3d00a9
fd5915c
84ccb77
d1a7f56
d6d2a7e
b46f7c8
8a7ba37
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not using the unitID it returns, you could instead have it return a bool and return that instead.
instead of returning false or running the is geo check before returning true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change made bdeb49a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a table of unitDefIDs instead, keyed using the id returns true. rather than getting the unit name and going through the entire table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with @robertthepie, also note table.contains already exists and this is basically reimplementing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh it's defined in the project. I'm not the most familiar with lua, couldn't believe that such a basic function didn't exist already. thanks for the heads up sautron.
changes made 8d84a20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Limiting it to only selling t2 seems counterintuitive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using the unit market to implement an exception -- Since that is the game flow players are used to. In general, buying 'anything' is a form of boosting, since you save the E cost, BP, and time. Allowing buy/sell of t1 cons lets you build safe eco anywhere, and you can easily "let" allies cap mexes arbitrarily at the start of the game. For example a front player could buy 2 cons from the backline, use them to cap the backliner secondary mexes and make winds, effectively boosting themselves.
By default tax unit sharing will only disable sharing of economy/labs. You are free to share combat units or other units freely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, this is a competitive modoption for a small subset of players. The ruleset has to cover everything to achieve the desired effect (also a similiar ruleset hasn't been tested before). I'm open to ideas to make the option selection more explanatory.
For ruleset changes maybe it would be better to discuss in https://discord.com/channels/549281623154229250/1253060706039890000
Tax Resource Sharing can be explained as: "You can't share eco/production, can't assist allied labs/blueprints, and resource sharing is taxed. You can buy/sell t2 at normal price via unit Market".