Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mission dialogue rmlui widget #4233
base: master
Are you sure you want to change the base?
Add mission dialogue rmlui widget #4233
Changes from all commits
9fd7e5a
d1a4b50
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the first time the document is hidden won't it be spamming calls to
document:Hide()
again? Even then, would be good to not even have the update callin when the dialogue is unused.I'd suggest registering the
:Update
callin once the dialog is shown, and deregistering when it's hidden. Deregistering on initialization.See
Beyond-All-Reason/luaui/Widgets/autocheat.lua
Lines 22 to 24 in 1107e22