Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add map name to minimap #4265

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

xenomote
Copy link

@xenomote xenomote commented Feb 1, 2025

Work done

Added the current map's name as a transparent text item on the minimap, to allow spectators to know which map is being played

Screenshots:

mapname

@WatchTheFort
Copy link
Member

Map name is in the lower left-hand corner of the map itself

@xenomote
Copy link
Author

xenomote commented Feb 1, 2025

Map name is in the lower left-hand corner of the map itself

I know, but whenever I watch commentary videos, unless they say the name of the map or intentionally point their camera at the map name in the corner, I won't see it. This way any video or screenshot of the game will make the map name clear

@WatchTheFort
Copy link
Member

If we're going to put the name on the minimap, it should go below the frame so it is both readable and doesn't obscure elements on the minimap.

@icexuick Thoughts on putting map name on the minimap?

@icexuick
Copy link
Collaborator

icexuick commented Feb 1, 2025

Well I understand it can be handy to know a map-name when viewing someones stream or some vid, as we do have quite the map-pool. On the other hand, the location is pretty good. In the new GUI it can fit well here too.

image

I'm okay with including this.

@xenomote xenomote requested review from keelefi and badosu February 1, 2025 19:07
@icexuick
Copy link
Collaborator

icexuick commented Feb 1, 2025

Maybe let it float below the minimap - though background changes there are also more intense.
maybe just a tad bigger/bolder font + shadow/outline.

@xenomote
Copy link
Author

xenomote commented Feb 3, 2025

@icexuick I extended the padding from the minimap to include the text at the bottom (as shown in the updated photo in the description), what do you think now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants