Improve the map_syncer script and fix tests #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On one of the servers, syncing was stuck for a few hours and after attaching to debugger, it was waiting for something on some TLS connection. Let's make sure that all socket operations time out after some reasonable timeout.
p2004a
force-pushed
the
p2004a-patch-1
branch
from
2da06b9 to
7df3b6b
Compare
Pinning tools version might be good idea to avoid spurious type and format checking issues when pushing unrelated changes.
p2004a
force-pushed
the
p2004a-patch-1
branch
from
7df3b6b to
616f4c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.