New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of spatial test macros #1823

Open

sprunk opened this issue Dec 17, 2024 · 0 comments

Labels

good first issue refactor

Collaborator

sprunk commented Dec 17, 2024

Refactor these into something less ugly.

spring/rts/Lua/LuaSyncedRead.cpp

Lines 2981 to 2984 in 4b47c24

    
           #define RECTANGLE_TEST            \ 
        
           	const float x = p.x;            \ 
        
           	const float z = p.z;            \ 
        
           	if ((x < xmin) || (x > xmax)) { \

spring/rts/Lua/LuaSyncedRead.cpp

Lines 3057 to 3059 in 4b47c24

    
           #define BOX_TEST_FULL             \ 
        
           	BOX_TEST                        \ 
        
           	RECTANGLE_TEST

sprunk added good first issue refactor labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment