Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Tester role to use $balancemode in unbossed lobby #357

Conversation

jauggy
Copy link
Member

@jauggy jauggy commented Jul 10, 2024

Context

In discussions with Sun_Tzu, they mentioned it was difficult to test a new balance algorithm as it requires boss and getting people to vote you boss is nearly impossible. https://discord.com/channels/549281623154229250/1245516077547389009/1260223439067811980

As a short term solution, and to enable us to test balance algorithm this PR will enable someone with Tester role to use $balancemode without being boss. However, they can only do this in a non-bossed lobby. It will automatically succeed and not trigger a vote

Test Steps

  1. Launch Lobby and run $balancemode split_one_chevs. It should fail
  2. Change this user to have Tester role. Login to Chobby again and retry the command. It should succeed.
  3. Add another user to the lobby and make that user boss. Try the command again and it should fail.

Results

1
2

@jauggy jauggy marked this pull request as ready for review July 10, 2024 22:13
@jauggy jauggy changed the title Tester an use balancemode Allow tester to use $balancemode in unbossed lobby Jul 10, 2024
@jauggy jauggy changed the title Allow tester to use $balancemode in unbossed lobby Allow Tester role to use $balancemode in unbossed lobby Jul 10, 2024
@L-e-x-o-n
Copy link
Collaborator

Code looks good, but I am not sure about the feature itself.
Right now only mods can bypass command restrictions. Lobby members should have an opinion on balance mode changes because it can affect things like parties. They might not want random testers changing it and breaking up parties for example. I think a better solution would be adding balancemode as a votable command.

@jauggy
Copy link
Member Author

jauggy commented Jul 13, 2024

Fair enough. Hopefully there is progress to make commands voteable:
https://discord.com/channels/549281623154229250/1258404939164680242/1258404942087979139

@jauggy jauggy marked this pull request as draft July 13, 2024 22:19
@L-e-x-o-n
Copy link
Collaborator

Fair enough. Hopefully there is progress to make commands voteable: https://discord.com/channels/549281623154229250/1258404939164680242/1258404942087979139

Progress has been made, !balancealgorithm <algorithm has been added.
Closing this PR for now.

@L-e-x-o-n L-e-x-o-n closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants