Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire up column config for resource #507

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

bezhanSalleh
Copy link
Owner

@bezhanSalleh bezhanSalleh commented Feb 17, 2025

this PR wires up the column and column span config for resources's checkbox when resource isn't simple.
this will allow to controll the checkboxes shown for permissions in the resources' tab separately from the other tabs column and column span config. previously the following two options were available but not wired-up.

->resourceCheckboxListColumns()
->resourceCheckboxListColumnSpan()

For checkboxes of other tabs and when resource is simple

->checkboxListColumns()
->checkboxListColumnSpan()

resolves #476

Copy link

what-the-diff bot commented Feb 17, 2025

PR Summary

  • Enhanced Method for Checking Headings
    The method for verifying the headings in the FilamentShield has been updated. This method will now use a helper function that checks if the heading has content, improving efficiency.

  • Improvements to Checkbox Component Handling
    The function that fetches the checkbox list components for a resource has been enhanced. It can now accept additional parameters (columns and columnSpan), giving more control over the layout of checkboxes.

  • Improved Function Call readability
    The way the checkbox list components are fetched throughout the file has been altered to use named arguments. This change makes our code easier to read and understand, in addition to enabling better configuration of columns.

  • Expanded Checkbox List Component Function
    The function that fetches the checkbox list components has been expanded. It now accepts two parameters: columns and columnSpan. This extension adds more flexibility and customization to the function, allowing for better control over the layout of checkboxes.

@bezhanSalleh bezhanSalleh merged commit 4f307fa into 3.x Feb 17, 2025
21 checks passed
@bezhanSalleh bezhanSalleh deleted the fix/wire-up-column-config-for-resource branch February 17, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant